feat: wait for active route handlers on page/context close #28414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

yury-s merged 2 commits into microsoft:main from yury-s:route-auto-remove

Dec 5, 2023

Member

yury-s commented Nov 30, 2023 •

edited

Loading

Reference #23781

This comment has been minimized.

Sign in to view

yury-s force-pushed the route-auto-remove branch from 1933303 to b9ee467 Compare

November 30, 2023 02:22

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

dgozman reviewed

View reviewed changes

packages/playwright-core/src/client/browserContext.ts Outdated Show resolved Hide resolved

packages/playwright-core/src/client/browserContext.ts Outdated Show resolved Hide resolved

yury-s force-pushed the route-auto-remove branch from b9ee467 to b479beb Compare

November 30, 2023 23:10

dgozman reviewed

View reviewed changes

packages/playwright-core/src/client/browserContext.ts Outdated Show resolved Hide resolved

packages/playwright-core/src/client/browserContext.ts Outdated Show resolved Hide resolved

packages/playwright-core/src/client/network.ts Outdated Show resolved Hide resolved

packages/playwright-core/src/client/network.ts Outdated Show resolved Hide resolved

packages/playwright-core/src/client/network.ts Outdated Show resolved Hide resolved

packages/playwright-core/src/client/page.ts Outdated Show resolved Hide resolved

packages/playwright-core/src/client/page.ts Outdated Show resolved Hide resolved

packages/playwright-core/src/client/page.ts Outdated Show resolved Hide resolved

docs/src/api/class-browsercontext.md Outdated Show resolved Hide resolved

tests/page/page-request-continue.spec.ts Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

yury-s force-pushed the route-auto-remove branch from 6f34c51 to d4da2d7 Compare

December 1, 2023 00:31

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

yury-s mentioned this pull request

fix: disable memory cache when intercepting in webkit #28458

Merged

yury-s force-pushed the route-auto-remove branch from d1e69d7 to fc88b92 Compare

December 1, 2023 22:58

This comment has been minimized.

Sign in to view

yury-s mentioned this pull request

fix(webkit): delay request event until requestIntercepted is received #28484

Merged

yury-s added a commit that referenced this pull request


          fix(webkit): delay request event until requestIntercepted is received (…

ab68d7b

…#28484)

Previously we were wrongly firing `route` event for the request which
are not in fact intercepted (e.g. requests from service worker).

Related #28414
Reference #23781

yury-s added 2 commits

December 4, 2023 13:04


          feat: wait for active route handlers on page/context close

16ad72f

Reference microsoft#23781


          Remove some nowaitfor

11f33b5

yury-s force-pushed the route-auto-remove branch from fc88b92 to 11f33b5 Compare

December 4, 2023 21:05

Contributor

github-actions bot commented Dec 4, 2023

Test results for "tests 1"

6 flaky

⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-ct.spec.ts:151:5 › should watch test
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks

26277 passed, 614 skipped
✔️✔️✔️

Merge workflow run.

yury-s merged commit 74e51d3 into microsoft:main

yury-s deleted the route-auto-remove branch

December 5, 2023 00:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet